I don't do onsite unless someone has a seminar and someone else is paying. Offsite for the places I typically go on vacation, VRBO rentals, timeshare rentals from TUG2.net and Redweek.com, and retail hotels for the quality of the room and amenities for the price are a better value in Orlando than anywhere else I typically travel. Flights fall into the middle for places we fly to in the US, so not overly high or overly low.
The expensive part, but I think it's a good value, are the tickets to go into the world class theme parks. Compared to tours that are pretty pricey, Broadway shows, concerts, etc., a day at one of the world class theme parks seems like a good value over all. This can really add up though. For those with large families I can see places where the main activity is free or practically free being very appealing -- beach days, hiking, freebie ranger tours at a national park. Or let's say my parent who recently paid for all of their children, grandchildren, and great grandchildren to do a family reunion vacation in Sedona, AZ (great choice) might have considered Orlando. A day at Disney or a few days at Disney for 16 instead now -- ouch.
For vacations though (a fun and frivolous thing), for us we have a vacation budget and the fun part is deciding what we want to do that is within that budget. Going somewhere you really don't want to go because it's a great value certainly doesn't make any sense. On the other hand, our family as ruled out some expensive good sounding trips to be able to do two trips for the year that sounded pretty good instead of just one.
DH doesn't care for Disney, so it's more often that not that I'll just fit in a short budget trip every year or two with just me and DS, maybe four nights/three days and leave it at that for Orlando/Disney. And usually we'll just visit one Disney park, do one day at SeaWorld, and maybe do something like the Titanic, Disney Springs, and visit relatives one of the days too.